-
Notifications
You must be signed in to change notification settings - Fork 115
WIP: Providing more optimization for the apache camel springboot example #60
WIP: Providing more optimization for the apache camel springboot example #60
Conversation
cf7a696
to
06aed65
Compare
…evfile Signed-off-by: Tibor Dancs <tdancs@redhat.com>
06aed65
to
06bd207
Compare
@ScrewTSW please explain why those changes will improve the workspace startup / stability in comparrison with the current values ? |
@apupier since you are the primary maintainer of the camel devfile adding you as a reviewer ;-) |
I've pretty much just reassigned the available resources based on the consumption that I've seen during the testing. Not saying it's a must, it's just a proposal. The current values work well |
@ScrewTSW could you please provide comparison of RAM consumption for the current version of devfile and the one from PR ? what are the benefits? If, as you said, current values work well why do we need further optimization? |
Current image memory consumption: static memory consumptions:
and the plugins defined in the devfile:
That leaves me 43.719MiB to be redistributed. The memory usage in the LSP peaks at 1250MiB during use and then falls back down as GC takes care of the objects. If you think there's no need to redistribute the extra memory that we have at our disposal, then this PR can be closed. |
@ScrewTSW sorry, but I probably do not understand the math.
In the PR you:
As I understand your motivation was to redistribute 43.719MiB, but in this PR you literally decrease RAM on 92 MB, and the most worrying thing for me that the RAM for java plugin, which is really memory hungry, is reduced. Am I missing smth ? |
I have been using those values before I was notified by Angel that he was able to get OOM on the LSP when only using 1Gi of memory. That's why I've sent my last comment with the analysis and the current status of the image. As I said there, this PR can be closed as irrelevant if you decide that you don't want me to do some magic with the 43Mi we have at our disposal. I just wanted to bring this image to full 3Gi memory usage (excluding the 3.4....Mi that remains because of the conversion of theia memory consumption from MB to MiB) |
@ScrewTSW you are using those values now in the current PR :-) |
Closing as irrelevant |
What does this PR do?
This PR adds further optimizations to the previous changes for the apache camel example
What issues does this PR fix or reference?
Follow-up: #46
Issue: https://github.com/redhat-developer/che-functional-tests/issues/556